Thread: [Warning] passing arg 1 of `strcmp' makes pointer from integer without a cast

Code:

#include <stdio.h>
int main(){
    int a=15 ;
    int  b =20 ;
    strcmp((a, "20") == 0) {
    printf("Correct!");
    }
    else {
        printf("noooooooooooooo!");
         }
    fflush(stdin);
    getchar();
      }

result : [Warning] passing arg 1 of `strcmp' makes pointer from integer without a cast

can someone explain to me the error message please and how to fix it , thank you

Code:

    strcmp( (a, "20") == 0 ) { /* Added spacing */

Do you see your mistake now?

Secondly, please do NOT call fflush() on stdin, that results in undefined behavior. You can only call fflush() on output streams and even then you only need to do it if you don't use a \n or receive input after printing.

Originally Posted by nonpuz

Code:

    strcmp( (a, "20") == 0 ) { /* Added spacing */

Do you see your mistake now?

Secondly, please do NOT call fflush() on stdin, that results in undefined behavior. You can only call fflush() on output streams and even then you only need to do it if you don't use a \n or receive input after printing.

sorry I dont see the mistake

You cannot use strcmp to compare a number and a string. They either both have to be numbers or they both have to be strings. If they're both string, then you can use strcmp().

Originally Posted by whiteflags

You cannot use strcmp to compare a number and a string. They either both have to be numbers or they both have to be strings. If they're both string, then you can use strcmp().

I changed to strcmp((a,b) == 0)
and still the same

Originally Posted by laserlight

That is because you are still making the same mistake, except that now you made it twice. The type of a and b is int. strcmp is declared as:

Code:

int strcmp(const char *s1, const char *s2);

Clearly, int is not compatible with const char*. In this case, strcmp looks entirely unnecessary. You could have written:

Code:

#include <stdio.h>

int main(void) {
    int a = 15;
    int b = 20 ;
    if (a == b) {
        printf("Correct!");
    } else {
        printf("noooooooooooooo!");
    }
    getchar();
    return 0;
}

Note that if you do want to call strcmp, you should #include <string.h>

ok here is the new code, it compile no error but when I type 15 it doesnt work as it supposed to

Code:

#include <stdio.h>
#include <string.h>
int main(void)
{
    char a[] = "15";
    char  b[1];
    printf("enter the secret word : ");
    scanf("%d",b);
    
    
    if(strcmp(a,b) == 0) 
    {
        printf("Correct!");
    }
    else 
    {
        printf("noooooooooooooo!");
    }
     
    fflush(stdin);
    getchar();
    return 0;
}

Originally Posted by fouzimedfouni

I changed to strcmp((a,b) == 0)
and still the same

Of course it is still the same.

Do you know about comparisons?

>	greater than operator (a > b)
<	less than operator (a < b)
>=	greater than or equal to operator (a >= b)
<=	less than or equal to operator (a <= b)
==	equal to operator (a == b)
!=	not equal to operator (a != b)

Strings are a special case - they cannot be compared lexicographically with these operators, so the strcmp() function was created and standardized to do that. As I indicated earlier, if they are both strings, then you can use strcmp(). If they are different types, like one is a number, and the other is a string, than nothing will help you. In C, you can only make a comparison between EITHER numbers or strings.

so strcmp() does compare with INT too ?

Originally Posted by whiteflags

No, it does not and it never will. For numbers, you need to pick one of the comparison operators.

thank you so much, I really appreciate your answer I see it now